-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a fill_region
method to the AStarGrid2D
#79495
Conversation
7cfb9f1
to
7063509
Compare
Maybe it should be an optional argument to the Or we can add a |
86897bd
to
e895865
Compare
AStarGrid2D
fill_region
method to the AStarGrid2D
@dalexeev I think |
e895865
to
7da476c
Compare
82a78a3
to
2a60114
Compare
2a60114
to
21af7eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to remind you about this check, sorry. The rest of the code and approach looks good to me. Not sure how much the GDScript loop is less performant though. Probably worth asking the proposal author, perhaps they meant some other problem?
21af7eb
to
034f5a4
Compare
For consistency, the following should be added to the description of the methods:
Also I'm a bit worried that there is no error/warning if the specified region is outside the grid region boundaries. |
034f5a4
to
5f56aa8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not really involved with the AStar classes but looks useful and fine.
Thanks! |
Thank you for implementing this and everyone involved |
Closes godotengine/godot-proposals#7276
by adding a propertyAdds thedefault_solid_enabled
to theAStarGrid2D
- after the user set it to true, the next call ofupdate
method will make all points solid.fill_region
method to assign the solid flag and weight_scale to the specified region on the gird.