-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] Add support for repackaging the generated UWP APPX file with makeappx
#79544
Conversation
I just learnt about clang formatting and git reset 😅 Hopefully, checks will pass this time :) |
makeappx
I also wrote a PowerShell script that solves this issue outside of Godot. It's not an embedded solution, but it's probably compatible with all UWP Godot 3.x releases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really have time to review in depth, but since it's working fine for @panreyes to ship games, I think we can merge.
makeappx
makeappx
Thanks! |
Cherry-picked for 3.5.3. |
I tried @panreyes script with the godot generated appx and I got this error: The path (/p) parameter is: "\?\D:\Godot Exports\toziuha_oota\uwp_free\toziuha_oota.appx" godot version: v3.5.3.stable.official [6c81413] |
This solves #79278
This commit makes Godot 3.5 use makeappx.exe to repack the APPX file generated when exporting for UWP platform.
Currently the integrated exporter has some unknown packaging error. I have tried to figure it out without success and, after that, I considered that the fastest and most practical solution is to just use Microsoft's official tool to repackage it.
How to make it work:
Requiring the use of makeappx.exe is not a big problem, since to sign the packages we also need the signtool.exe tool. Both tools are part of the Windows 10/11 SDK.
With this change, and this one godotengine/godot-build-scripts#80 (comment) , Godot 3.5 will correctly be able to export to UWP format for XBOX. I have tested it and it works flawlessly for most 2D games at least.
Production edit: Closes #30558