-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add drag'n'drop text option for LineEdit
and RichTextLabel
#79563
Add drag'n'drop text option for LineEdit
and RichTextLabel
#79563
Conversation
7d5e0d8
to
fd1920d
Compare
fd1920d
to
c02c8b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation comment should be addressed, otherwise seems fine.
c02c8b9
to
cfe98c5
Compare
LineEdit
and RichTextLabel
@danny88881 You have just merged the upstream master into your branch. If you want to update your branch with the current master you need to do a rebase instead. Your PR should only contain your own changes, and nothing else. |
ad0c7af
to
cfe98c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we have the feature in TextEdit, it seems to make sense to include in LineEdit and RTL too.
Thanks! And congrats for your first merged Godot contribution 🎉 |
Extends the functionality of #62221 to LineEdit and RichTextLabel and addresses godotengine/godot-proposals#7297
The additional changes in LineEdit are to make its behavior more similar to TextEdit and RichTextLabel when drag_and_drop_selection_enabled is set to false, with the new form mirroring TextEdit's implementation.
(first ever pull request, let me know if I've done anything wrong)