Show valid types in SceneTreeDialog #79593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
force-pushed
the
duck_typing_dialog
branch
from
1fb52f8
to
b9b30ca
Compare
KoBeWi
force-pushed
the
duck_typing_dialog
branch
from
b9b30ca
to
a5aad8a
Compare
YuriSizov
reviewed
Aug 3, 2023
editor/gui/scene_tree_editor.cpp
Outdated
Comment on lines
1512
to
1532
| TextureRect *trect = memnew(TextureRect); | ||
| hflow->add_child(trect); | ||
| trect->set_expand_mode(TextureRect::EXPAND_IGNORE_SIZE); | ||
| trect->set_stretch_mode(TextureRect::STRETCH_KEEP_ASPECT_CENTERED); | ||
| trect->set_meta("type", type); | ||
| valid_type_icons.push_back(trect); | ||
|
|
||
| Label *label = memnew(Label); | ||
| hflow->add_child(label); | ||
| label->set_text(type); | ||
| label->set_auto_translate(false); |
There was a problem hiding this comment.
We should group them in hbox, otherwise the label and the icon can end up on separate lines.
YuriSizov
approved these changes
Aug 3, 2023
KoBeWi
force-pushed
the
duck_typing_dialog
branch
from
a5aad8a
to
44d2fab
Compare
|
You have shadowing issues 🙃 |
KoBeWi
force-pushed
the
duck_typing_dialog
branch
from
44d2fab
to
05ab444
Compare
YuriSizov
approved these changes
Aug 4, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When picking node for Node/NodePath property, allowed type is now displayed at the top:
Multiple types:
Closes #62483