Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when deleting tileset terrains #79618

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Fix crash when deleting tileset terrains #79618

merged 1 commit into from
Jul 21, 2023

Conversation

HolonProduction
Copy link
Member

Fixes: #79583

@YuriSizov YuriSizov modified the milestones: 4.x, 4.2 Jul 18, 2023
@groud
Copy link
Member

groud commented Jul 19, 2023

LGTM!

@YuriSizov YuriSizov changed the title Fix crash when deleting terrains Fix crash when deleting tileset terrains Jul 21, 2023
@YuriSizov YuriSizov merged commit 7835d42 into godotengine:master Jul 21, 2023
13 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@dandeliondino dandeliondino mentioned this pull request Sep 14, 2023
Open
@HolonProduction HolonProduction deleted the deleting-terrains-crash branch December 9, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@groud groud groud approved these changes

Assignees
No one assigned
Labels
bug crash topic:editor topic:2d
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Deleting Terrains in the tileset resource, on terrain sets, will cause a crash.
4 participants
@HolonProduction @groud @YuriSizov @AThousandShips