Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert the change of the limit for interpolation of F0 for dielectrics and metals for Screen Space Reflections #79624

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Revert the change of the limit for interpolation of F0 for dielectrics and metals for Screen Space Reflections #79624

merged 1 commit into from
Jul 21, 2023

Commits on Jul 18, 2023

  1. Revert the change of the limit for interpolation of R0 with respect t… 

    …o metallic and SSR

Commit 2c000cb changed the interpolation limits from (0.04, 1.0) to (0.04, 0.37). This is incorrect, as we want to have an F0 of 0.04 for dielectrics (materials with metalness of 0.0) and an F0 of 1.0 for metals.
The Schlick approximation uses an F0 of 0.04 for all dielectrics and it's good enough.
Having it lower than 1.0 leads to an incorrect application of the Fresnel effect for metals and leads to bugs like godotengine#79549
    @mandryskowski
    mandryskowski authored Jul 18, 2023
    Configuration menu
    Copy the full SHA
    33e46aa View commit details
    Browse the repository at this point in the history