-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix script name of Hant and Hans #79654
Conversation
The formal ISO 15924 names are "Han (Simplified/Traditional variant)", could be good to go with that for standard Hani in turn is named "Han (Hanzi, Kanji, Hanja)" The list even cites this standard as reference |
Yeah, that could be an option. My concern is that the name is used by |
That still happens for some entries though, like Otherwise just "Han, Simplified/Traditional variant" |
core/string/locales.h
Outdated
@@ -1057,8 +1057,8 @@ static const char *script_list[][2] = { | |||
{ "Hangul", "Hang" }, | |||
{ "Han", "Hani" }, | |||
{ "Hanunoo", "Hano" }, | |||
{ "Simplified", "Hans" }, | |||
{ "Traditional", "Hant" }, | |||
{ "Han (Simplified variant)", "Hans" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this have the same issue that you said about double parentheses?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we already have such names and this is a standard name, I think it might be acceptable.
But yeah, I still think "Simplified/Traditional Han" would look better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only other case is Myanmar (Burmese)
, maybe it's better to change it to Myanmar / Burmese
as well and use Simplified Han
+ Traditional Han
to avoid extra parentheses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks! |
A script named "Traditional" or "Simplified" makes no sense :P
This PR changes the names to "Han (Traditional variant)" and "Han (Simplified variant)".
Note: This makes
get_locale_name()
returnChinese (Han (Simplified variant))
forzh-Hans
. But script name with parentheses already exists forMymr
.p.s. The generalized CJK
hani
was correctly named "Han".