-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] Prevent double input events on gamepad when running through steam input #79706
Conversation
Since this largely copies the code from that PR I'd suggest attributation in the commit itself |
Please squash commits into one as well. Make sure that the final commit has a short but descriptive message (the title of this PR is a good option). See this documentation, if you need help with squashing. For the attribution you can use the |
@YuriSizov, squashed, reworked commit message with attribution. |
Needs to be with the GitHub email of the user to work, and put it on a separate line, you can find it in the |
@AThousandShips, updated. |
Still doesn't work, I think you need to add the user name and email, with parentheses around the email Edit: with |
@AThousandShips, okie doke. Done. Hopefully, it works. |
Still no, try adding a space after |
@AThousandShips, what are we looking for? So I might look to know. Is there some hypertext that should be observed somewhere? |
You can find documentation about co-authoring here: |
It should have their icon show up by the commit, and say that they authored it by your name, unsure what breaks here, they might have changed their email on their profile |
I see. Looking at another commit I'm not seeing usage of the suffix "Yokai" in my desktop git application. However, looking through github I do. An example of their commits: 8de98db @Eoin-ONeill-Yokai, have you experienced git having issues with that name as such? |
If you use the command line you'll see the exact usage in the log, it is |
@AThousandShips, good catch. No dice, as far as I can tell. |
See the instructions, needs two blank lines, sorry missed that myself
|
…am input godotengine#79706 Co-authored-by: Eoin O'Neill <[email protected]>
Success! |
Thanks for doing this on my behalf! I got a bit busy and forgot about Godot 3 :) |
@Eoin-ONeill-Yokai, thanks for doing it to begin with. |
…am input godotengine#79706 Co-authored-by: Eoin O'Neill <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this got forgotten. It looks to match the master PR and looks fairly sensible, I'm assuming author has tested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Tested. |
Thanks! And congrats for your first merged Godot contribution 🎉 |
Backported request #76045 from Eoin-ONeill-Yokai/steaminput-fix to branch 3.x.