Make the occlusion culling debug draw mode draw a translucent overlay #79733
+37
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for easy, depth-aware navigation in the 3D editor while being able to view which meshes are occluders and which meshes aren't. Co-authored-by: myaaaaaaaaa <[email protected]>
Calinou
force-pushed
the
occlusion-culling-debug-draw-translucency
branch
from
34195cf
to
63a59c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for easy, depth-aware navigation in the 3D editor while being able to view which meshes are occluders and which meshes aren't.
I've tested this change with both Forward+ and Mobile rendering methods. No Vulkan validation errors are reported when running with
--gpu-validationon either rendering method. (The Compatibility rendering method currently doesn't support most debug draw modes, including the occlusion culling buffer. Occlusion culling itself does work though.)Thanks @myaaaaaaaaa for the help 🙂
Testing project: test_occlusion_culling_buffer.zip
Preview
The red overlay on the sides is more noticeable at a higher FOV, and wasn't introduced by this PR. Previously, it was rendered as a dark vignette. I'm not sure what's causing this.