Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues in C# documentation comments #79748

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Jul 21, 2023

  • changes instances of see paramref to paramref name
  • specifies real_t for ambiguous methods

Copy link
Member

@RedworkDE RedworkDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise, according to https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/xmldoc/recommended-tags#paramref the paramref change is correct and the old syntax doesn't really exist.

modules/mono/glue/GodotSharp/GodotSharp/Core/Callable.cs Outdated Show resolved Hide resolved
• changes instances of `see paramref` to `paramref name`
• specifies `real_t` for ambiguous methods
@Repiteo Repiteo force-pushed the dotnet-documentation-fixes branch from f10998e to 0bfc52b Compare July 21, 2023 15:35
@YuriSizov YuriSizov modified the milestones: 4.x, 4.2 Jul 25, 2023
@YuriSizov YuriSizov changed the title Fixes to existing C# documentation Fix issues in C# documentation comments Jul 25, 2023
@YuriSizov YuriSizov merged commit 000bf37 into godotengine:master Jul 25, 2023
13 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@Repiteo Repiteo deleted the dotnet-documentation-fixes branch July 25, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants