Cosmetic changes in GLTF node generation code #79775
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has some internal renames in the GLTF node generation code and some reordering.
_generate_scene_node
and_generate_skeleton_bone_node
arguments to put the node index first. The index is more "core" information to the node generation so it should come first. This may seem slight/pedantic but it was prompted by another change coming after this PR in which it will make more sense to order the arguments this way.p_
prefix at the start of parameter names in_generate_scene_node
._assign_scene_names
to_assign_node_names
because it assigns node names.Ref<GLTFNode> n
togltf_node
to improve readability.