Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when executing TileMap.fix_invalid_tiles #79851

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Fix crash when executing TileMap.fix_invalid_tiles #79851

merged 1 commit into from
Jul 24, 2023

Conversation

timothyqiu
Copy link
Member

Fixes #79845

TileSet could be null.

@timothyqiu timothyqiu added this to the 4.2 milestone Jul 24, 2023
@timothyqiu timothyqiu requested a review from a team as a code owner July 24, 2023 10:57
groud
groud requested changes Jul 24, 2023
View reviewed changes
scene/2d/tile_map.cpp Outdated Show resolved Hide resolved
KoBeWi
KoBeWi reviewed Jul 24, 2023
View reviewed changes
scene/2d/tile_map.cpp Outdated Show resolved Hide resolved
@YuriSizov YuriSizov merged commit f618701 into godotengine:master Jul 24, 2023
13 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@timothyqiu timothyqiu deleted the null-tileset branch July 24, 2023 17:53
@Lokno Lokno mentioned this pull request Jul 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi left review comments

@groud groud groud approved these changes

Assignees
No one assigned
Labels
bug crash topic:2d
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Executing TileMap.fix_invalid_tiles functions crashes Godot
4 participants
@timothyqiu @YuriSizov @KoBeWi @groud