Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDScript: Add validation for @export_node_path annotation arguments #79935

Merged
merged 1 commit into from
Aug 1, 2023
Merged

GDScript: Add validation for @export_node_path annotation arguments #79935

merged 1 commit into from
Aug 1, 2023

Conversation

dalexeev
Copy link
Member

@dalexeev dalexeev commented Jul 26, 2023 •
edited
Loading

@dalexeev dalexeev added this to the 4.2 milestone Jul 26, 2023
@dalexeev dalexeev requested a review from a team as a code owner July 26, 2023 17:45
adamscott
adamscott approved these changes Jul 30, 2023
View reviewed changes
Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me!

@YuriSizov YuriSizov merged commit 68a49c4 into godotengine:master Aug 1, 2023
13 checks passed
@dalexeev dalexeev deleted the gds-validate-node-path-annotation branch August 1, 2023 15:40
@YuriSizov
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamscott adamscott adamscott approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor topic:gdscript
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@dalexeev @YuriSizov @adamscott