fixing typo in _customize_scene description #79993
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
|
Btw: I am probably going to work on a bit more documentation for this class today, as it was a huge pain to wrap my head around ... |
dalexeev
added
bug
documentation
cherrypick:4.1
akien-mga
added a commit
that referenced
this pull request
Aug 7, 2023
Also includes typo fixes from #79993, #80068, #80276, and #80303. Co-authored-by: betalars <[email protected]> Co-authored-by: spaceyjase <[email protected]> Co-authored-by: Swarkin <[email protected]> Co-authored-by: Raul Santos <[email protected]>
|
I included this fix together with other typo fixes in faaf27f. Thanks for the contribution! |
akien-mga
added
archived
and removed
cherrypick:4.1
IntangibleMatter
pushed a commit
to IntangibleMatter/godot
that referenced
this pull request
Aug 13, 2023
Also includes typo fixes from godotengine#79993, godotengine#80068, godotengine#80276, and godotengine#80303. Co-authored-by: betalars <[email protected]> Co-authored-by: spaceyjase <[email protected]> Co-authored-by: Swarkin <[email protected]> Co-authored-by: Raul Santos <[email protected]>
akien-mga
added a commit
to akien-mga/godot
that referenced
this pull request
Oct 3, 2023
Also includes typo fixes from godotengine#79993, godotengine#80068, godotengine#80276, and godotengine#80303. Co-authored-by: betalars <[email protected]> Co-authored-by: spaceyjase <[email protected]> Co-authored-by: Swarkin <[email protected]> Co-authored-by: Raul Santos <[email protected]> (cherry picked from commit faaf27f)
mandryskowski
pushed a commit
to mandryskowski/godot
that referenced
this pull request
Oct 11, 2023
Also includes typo fixes from godotengine#79993, godotengine#80068, godotengine#80276, and godotengine#80303. Co-authored-by: betalars <[email protected]> Co-authored-by: spaceyjase <[email protected]> Co-authored-by: Swarkin <[email protected]> Co-authored-by: Raul Santos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_customize_sceneis called when_begin_customize_scenesreturns true, not when_begin_customize_resourcesreturns true.