Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UndoRedo icon #80102

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Add UndoRedo icon #80102

merged 1 commit into from
Aug 7, 2023

Conversation

MewPurPur
Copy link
Contributor

UndoRedo is an Object, but its icon still shows up in some places, so why not?

image

image

image

image

@MewPurPur MewPurPur requested a review from a team as a code owner August 1, 2023 06:01
@dalexeev dalexeev added this to the 4.x milestone Aug 1, 2023
@KoBeWi
Copy link
Member

KoBeWi commented Aug 1, 2023

Looks kind of like refresh icon.

@MewPurPur
Copy link
Contributor Author

We also have Loop.svg which is a bit similar but not strikingly so.

image

image

So I understand how this association could come up.

I personally really associate these little curves at the start of arrows with Undo & Redo, in Godot we don't have any buttons for these things though.

image

@KoBeWi
Copy link
Member

KoBeWi commented Aug 1, 2023

What if the icon only included Undo? I think this one looks fine:
image

btw there is also EditorUndoRedoManager, maybe you can come up with something as well (undo + manager?)

EDIT:
Seems like we have some rotate icons that look similar.

@MewPurPur
Copy link
Contributor Author

MewPurPur commented Aug 1, 2023

Yeah, the rotate icons and History.svg are too clashy imo. I'm down with only having Undo as it's the more iconic one, I'm personally keen on these two:

image

image

I don't know an awful lot about EditorUndoRedoManager, can't think of much either

@KoBeWi
Copy link
Member

KoBeWi commented Aug 1, 2023

The lower one looks ok.
The upper one is like "Back".

I don't know an awful lot about EditorUndoRedoManager, can't think of much either

It's basically a wrapper for UndoRedo that works in scene context.
idk, put a suit on UndoRedo texture and it will look like a manager. Probably.
(jk)

@YuriSizov
Copy link
Contributor

I think this has closer association with a "history" type of icon, some combination of an arrow and a clock face.

@MewPurPur
Copy link
Contributor Author

image

I don't wanna compile Godot just to show how it looks in the editor, but it's not a convoluted icon so I don't see any way it'd look bad at 16x16

@akien-mga akien-mga modified the milestones: 4.x, 4.2 Aug 7, 2023
@akien-mga akien-mga merged commit c833827 into godotengine:master Aug 7, 2023
14 checks passed
@akien-mga
Copy link
Member

Thanks!

@MewPurPur MewPurPur deleted the undo-redo-icon branch August 8, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants