Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "a number is required" error when printing RID #80122

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Fix "a number is required" error when printing RID #80122

merged 1 commit into from
Aug 1, 2023

Conversation

timothyqiu
Copy link
Member

Got the following error when calling TileMap::get_coords_for_body_rid() with a wrong RID.

ERROR: a number is required

@timothyqiu timothyqiu added bug topic:2d cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Aug 1, 2023
@timothyqiu timothyqiu added this to the 4.2 milestone Aug 1, 2023
@timothyqiu timothyqiu requested a review from a team as a code owner August 1, 2023 15:34
@YuriSizov YuriSizov merged commit 9fe9922 into godotengine:master Aug 1, 2023
13 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@timothyqiu timothyqiu deleted the rid-id branch August 1, 2023 23:50
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 19, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.3. The code is different in 4.1, but I think the change still applies, so I adapted it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:2d
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@timothyqiu @YuriSizov @akien-mga