-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further separate icon from text of buttons in both editor and default themes #80285
Conversation
f85257f
to
df39400
Compare
df39400
to
05c572e
Compare
A separation of 4 is also the default on other UI libraries like JavaFX. So it seems like a good choice. |
This will change existing projects' theme appearances if they don't override the constants in question. I think it's a good change, but it's unfortunately technically a breaking change 🙁 |
@Calinou This has already been talked about in the dev chat, and acceptable for a minor release: https://docs.godotengine.org/en/stable/about/release_policy.html#what-are-the-criteria-for-compatibility-across-engine-versions |
That particular note is for the default project theme, not user-made themes that happen not to override the Either way, the visual difference with this PR is small, except in games with a pixel art appearance that use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a good change to me.
As long as we document it clearly in the "Changes" section of the changelog, should be fine for 4.2.
05c572e
to
99c6d1c
Compare
@akien-mga Just as I removed the default theme changes... 🥲 |
99c6d1c
to
77d3299
Compare
Well I didn't consider it as an option but yes, it could make sense to preserve compat for the default theme and only change the editor theme. |
Well, now I just reverted them back. So I hope we can just go with it... |
77d3299
to
98bdb56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! |
I've noticed that the the icon and text separation in buttons seems a little too modest, making it look like there's almost no separation at all. This PR makes so that the default separation is 4 instead of 2, and it also removes the
BottomPanelButton
theme variation, as I don't feel like it's needed after this change.