Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve PackedScene unit test for complex scene #80423

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Improve PackedScene unit test for complex scene #80423

merged 1 commit into from
Aug 10, 2023

Conversation

sepTN
Copy link
Contributor

@sepTN sepTN commented Aug 8, 2023

Adding additional unit test for PackedScene to handle more complex scene with child nodes, and ensures that the hierarchy is correctly preserved when instantiated.

Link back to #43440

@sepTN sepTN requested a review from a team as a code owner August 8, 2023 17:19
@AThousandShips AThousandShips added this to the 4.x milestone Aug 9, 2023
Sauermann
Sauermann approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@Sauermann Sauermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is looking good to me.

@akien-mga akien-mga modified the milestones: 4.x, 4.2 Aug 10, 2023
@akien-mga akien-mga merged commit 8dabb4c into godotengine:master Aug 10, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou mentioned this pull request Feb 21, 2024
Open
99 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@Sauermann Sauermann Sauermann approved these changes

Assignees
No one assigned
Labels
enhancement topic:core topic:tests
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@sepTN @akien-mga @Sauermann @AThousandShips