Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Fix Tween cheatsheet URL #80495

Merged
merged 1 commit into from
Aug 18, 2023
Merged

[3.x] Fix Tween cheatsheet URL #80495

merged 1 commit into from
Aug 18, 2023

Conversation

sk757a
Copy link

@sk757a sk757a commented Aug 10, 2023

No description provided.

@sk757a sk757a requested a review from a team as a code owner August 10, 2023 20:35
@AThousandShips
Copy link
Member

AThousandShips commented Aug 10, 2023 •
edited
Loading

Thank you for your work

Wrong link, it should be 3.6, this link:
"https://raw.githubusercontent.com/godotengine/godot-docs/3.6/img/tween_cheatsheet.png"
I'm not sure the 4.1 sheet applies correctly for the 3.x case, for example the "spring" mode doesn't exist in 3.x, only in 4.1:
3.6
4.1

@AThousandShips AThousandShips changed the title Fix tween_cheatsheet 404 in Tween.xml [3.x] Fix tween_cheatsheet 404 in Tween.xml Aug 10, 2023
@AThousandShips AThousandShips added this to the 3.x milestone Aug 14, 2023
@akien-mga akien-mga modified the milestones: 3.x, 3.6 Aug 18, 2023
@akien-mga akien-mga changed the title [3.x] Fix tween_cheatsheet 404 in Tween.xml [3.x] Fix Tween cheatsheet URL Aug 18, 2023
@akien-mga
Copy link
Member

I pushed an update to also do the change in SceneTreeTween docs.

@akien-mga akien-mga merged commit 840fdb7 into godotengine:3.x Aug 18, 2023
13 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@AThousandShips AThousandShips mentioned this pull request Sep 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug documentation
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.
3 participants
@sk757a @AThousandShips @akien-mga