Allow functions with multiple arguments inside EditorSpinSlider #80541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MewPurPur
force-pushed
the
buff-editorspinslider
branch
from
78cf7da
to
c1eadf0
Compare
MewPurPur
changed the title
MewPurPur
force-pushed
the
buff-editorspinslider
branch
from
c1eadf0
to
e734db0
Compare
|
Closing as the PR mentioned above does it way better than me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If inside a function, don't convert commas
,into periods..If you've wondered why functions with multiple arguments like
pow()aren't supported in number input fields, it's because Godot indiscriminately converted commas into periods to support European keyboard layouts. But if you've typed a function, you're entering a programming context so you wouldn't expect commas to work as decimal separators.Advancing godotengine/godot-proposals#6988 a little.
One concern I thought about is how this PR will make
sin(7,5)not work, even though something like this could be considered a mathematical context. But I think this is more of an edge case than before.