Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: paramref now properly tagged in documentation #80630

Merged
merged 1 commit into from
Aug 16, 2023
Merged

C#: paramref now properly tagged in documentation #80630

merged 1 commit into from
Aug 16, 2023

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Aug 14, 2023

Extracted from #79475

  • If part of a signal, the old documentation style is used, as it points to a delegate & doesn't have actual parameters to reference

@Repiteo Repiteo requested a review from a team as a code owner August 14, 2023 16:47
@Repiteo Repiteo mentioned this pull request Aug 14, 2023
Closed
@raulsntos raulsntos added this to the 4.2 milestone Aug 14, 2023
raulsntos
raulsntos approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nit comments, but otherwise looks good to me.

modules/mono/editor/bindings_generator.cpp Outdated Show resolved Hide resolved
modules/mono/editor/bindings_generator.cpp Outdated Show resolved Hide resolved
@Repiteo
C#: paramref now properly tagged in documentation
10cc461 
• If part of a signal, the old documentation style is used, as it points to a delegate & doesn't have actual parameters to reference
@akien-mga akien-mga merged commit db1a5dc into godotengine:master Aug 16, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@Repiteo Repiteo deleted the C#-paramref branch August 16, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@raulsntos raulsntos raulsntos approved these changes

Assignees
No one assigned
Labels
enhancement topic:buildsystem topic:dotnet
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@Repiteo @akien-mga @raulsntos @AThousandShips