Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix casts of XR handles in OpenXRExtensionWrapperExtension #80656

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Fix casts of XR handles in OpenXRExtensionWrapperExtension #80656

merged 1 commit into from
Aug 16, 2023

Conversation

konczg
Copy link
Contributor

@konczg konczg commented Aug 15, 2023 •
edited by bitsawer
Loading

On 32-bit systems, XR handles are defined as uint64_t, so conversion from XR handles to uint64_t requires C-style casts.

@konczg
Fix casts of XR handles in OpenXRExtensionWrapperExtension
61455ff 
On 32-bit systems, XR handles are defined as uint64_t, so conversion from XR handles to uint64_t requires C-style casts.
@konczg konczg mentioned this pull request Aug 15, 2023
Closed
@dsnopek dsnopek requested a review from a team August 15, 2023 13:09
@dsnopek dsnopek added this to the 4.x milestone Aug 15, 2023
dsnopek
dsnopek approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me

@akien-mga akien-mga modified the milestones: 4.x, 4.2 Aug 15, 2023
BastiaanOlij
BastiaanOlij approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm too!

@akien-mga akien-mga merged commit 3d1e135 into godotengine:master Aug 16, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsnopek dsnopek dsnopek approved these changes

@BastiaanOlij BastiaanOlij BastiaanOlij approved these changes

Assignees
No one assigned
Labels
bug topic:xr
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Cannot build templates for 32-bit Windows
4 participants
@konczg @akien-mga @dsnopek @BastiaanOlij