-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document pick_random
for empty arrays
#80694
Conversation
Executing
So I'm not entirely convinced, that documenting a behavior which causes an error message is warranted. |
We can possibly document that it requires a non empty array, though that should be obvious, as it says "from" |
Sounds good. The documentation of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, clear and concise
Could you squash the commits? See PR workflow for instructions. |
afea8fa
to
30d4d1c
Compare
pick_random
for empty arrays
Thanks! |
No description provided.