SCons: Enable /WX on LINKFLAGS for MSVC with werror=yes
#80711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
enhancement
platform:windows
topic:buildsystem
cherrypick:3.x
akien-mga
force-pushed
the
scons-msvc-werror-link-flags
branch
from
4d6a55a
to
aa4b9e9
Compare
akien-mga
force-pushed
the
scons-msvc-werror-link-flags
branch
from
aa4b9e9
to
30bdb23
Compare
bruvzg
approved these changes
Aug 18, 2023
|
Cherry-picked for 3.6. |
akien-mga
removed
the
cherrypick:3.x
|
Cherry-picked for 4.1.2. |
YuriSizov
removed
the
cherrypick:4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft as it should fail due to #80095 (comment).Edit: Fixed by #80713.
For the record, the option is already enabled in godot-cpp, unconditionally: https://github.com/godotengine/godot-cpp/blob/master/tools/windows.py#L35
I guess it makes sense there as we don't want potential linking warnings that would impact loading dynamic libraries.