Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase h separation of editor's PopupMenu #80830

Closed
wants to merge 1 commit into from

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Aug 20, 2023

Before:

After:
image
(this is scene dock's ⋮ menu)

Closes #81964

@akien-mga
Copy link
Member

Looks better, though I notice there seems to be more spacing between the separation line and the left of the icon, than on the right of the label. Can this be tweaked?

@KoBeWi
Copy link
Member Author

KoBeWi commented Aug 20, 2023

Not with a theme constant AFAIK.

@YuriSizov
Copy link
Contributor

YuriSizov commented Oct 17, 2023

Looks better, though I notice there seems to be more spacing between the separation line and the left of the icon, than on the right of the label. Can this be tweaked?

I think this is actually the source of the issue. There is clearly enough space allocated to both the separation and the icon, but the icon itself is not drawn centered to that space. I'm looking into it, but the drawing code is a mess.

Edit: Okay, it's because of the item padding added on both sides. It shifts the icon, but not much else. I'll make a PR.

@YuriSizov
Copy link
Contributor

Done #83517.

@KoBeWi
Copy link
Member Author

KoBeWi commented Oct 18, 2023

Superseded by #83517

@KoBeWi KoBeWi closed this Oct 18, 2023
@KoBeWi KoBeWi deleted the attack_of_the_separatists branch October 18, 2023 09:44
@YuriSizov YuriSizov removed this from the 4.x milestone Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sub-resource menu has icons too close to titles
3 participants