[3.x] Core: Add recursion level check for Array and Dictionary hashing
#80888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalexeev
added
bug
topic:core
crash
cherrypick:3.5
| return recursive_hash(0); | ||
| } | ||
|
|
||
| uint32_t Array::recursive_hash(int p_recursion_count) const { |
There was a problem hiding this comment.
Let me suggest declaring these as (private) uint32_t T::_hash(int p_recursion_count = 0) const.
There was a problem hiding this comment.
Makes sense. I just copied it from 4.x though.
There was a problem hiding this comment.
Oh, if the one in 4.x is already merged, just feel free to ignore me (or make a PR for 4.x if you think my suggestion has enough merit).
RandomShaper
approved these changes
Aug 22, 2023
|
Thanks! |
|
Cherry-picked for 3.5.3. |
akien-mga
removed
the
cherrypick:3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dictionaryas own key crashes Godot #44195.recursive_equal()and other things are not copied as it would break compatibility.It also prevents crashes in cases like: