Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep _export_begin()'s path argument always consistent #81016

Conversation

YeldhamDev
Copy link
Member

@YeldhamDev YeldhamDev commented Aug 26, 2023

Currently, the path argument given by _export_begin() will show a simplified path if exporting a single preset, or an absolute one if exporting them all at once. This PR makes sure that in both cases the simplified one is given.

@akien-mga
Copy link
Member

It seems to be export_project and not export_being (typo for export_begin I suppose, but that doesn't seem to be the name either?).

@YeldhamDev YeldhamDev changed the title Keep _export_being()'s path argument always consistent Keep _export_begin()'s path argument always consistent Aug 27, 2023
@YeldhamDev YeldhamDev force-pushed the took_me_a_while_to_discover_why_my_plugin_was_acting_weird branch from d6cd401 to cc859fd Compare August 27, 2023 14:07
@YeldhamDev
Copy link
Member Author

@akien-mga The path is given to the _export_begin() method on scripts that extend EditorExportPlugin.

@akien-mga akien-mga merged commit b5b87b3 into godotengine:master Aug 28, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@YeldhamDev YeldhamDev deleted the took_me_a_while_to_discover_why_my_plugin_was_acting_weird branch August 28, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants