Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Quick Open not opening binary resources #81068

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Aug 28, 2023

When you save a Resource with .res extension, you won't be able to open it with Quick Open (Shift + Alt + O). There was a bug in opening logic, because it determined what to do based on resource extension. .res is one of scene extensions, so the resource was opened as scene, resulting in empty scene tab.
This PR changes it to use actual resource type instead of extension, so scenes and regular resources are properly differentiated.

@KoBeWi KoBeWi added this to the 4.2 milestone Aug 28, 2023
@akien-mga akien-mga merged commit 031f6de into godotengine:master Aug 28, 2023
15 checks passed
@KoBeWi KoBeWi deleted the is_scene_a_resource branch August 28, 2023 13:08
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants