[3.x] GDScript: Don't warn about RETURN_VALUE_DISCARDED by default
#81089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mickeon
approved these changes
Feb 25, 2024
akien-mga
changed the title
RETURN_VALUE_DISCARDED by default
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #69002. Turns out
4.xhas a lot of changes in the GDScript module so cherry-picking it directly is out of question.I can't really see the reason to keep it enabled by default even with
3.xespecially when more of new features cherry-picked from4.xintroduce a lot of discarded values. Anyway, this left to be justified by the maintainer since warnings in3.xaren't apparent in its own IDE but it's very annoying for users that use external editors.This is a re-do pull request from a broken #79077 branch.