-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new methods to AABB
and Rect2
classes
#81096
base: master
Are you sure you want to change the base?
Conversation
In the future please be aware of when people have already said they wanted to solve an issue like this case, first ask if they are still working on it, otherwise you might cost someone a lot of lost time when you grab the issue |
This doesn't solve the linked issue unless you also integrate these methods with the animation |
Alright, I'll pay more attention next time. For sure isn't nice to waste someone's time! |
@AThousandShips can you please give me more info of how can I do it? |
I'll try find the relevant code later today |
Thanks, really appreciate it! I'll come back to this later as well, I'll keep looking further into the code trying to understand what else is needed to implement/modify. |
I'd suggest looking at
Also might be good to look into adding the same to |
The missing function is not the only problem, but the substance of the problem is the need to force a positive value with abs() at the end of the interpolation function. |
@AThousandShips @TokageItLab I've implemented the following methods for |
lerp()
and cubic_interpolate()
methods to Rect2
classlerp()
and cubic_interpolate()
methods to Rect2
and AABB
classes
lerp()
and cubic_interpolate()
methods to Rect2
and AABB
classesRect2
and AABB
classes
b96c8d7
to
dbf187e
Compare
dbf187e
to
a054b78
Compare
Rect2
and AABB
classesAABB
and Rect2
classes
04d1f21
to
7b3a10c
Compare
Please use |
7b3a10c
to
9ff2e2f
Compare
@TokageItLab can you take a look in this PR? I've made the requested changes |
- Add lerp(), cubic_interpolate() and cubic_interpolate_in_time() methods to AABB and Rect2 classes. - Modify the animation.cpp file. Add new methods to AABB and Rect2 classes - Add lerp(), cubic_interpolate() and cubic_interpolate_in_time() methods to AABB and Rect2 classes. - Modify the animation.cpp file.
@AThousandShips I've modified what you've pointed out. I've also solved the conflicts. |
What I did
AABB
andRect2
classes:lerp()
,cubic_interpolate()
andcubic_interpolate_in_time()
;Animation
class:_cubic_interpolate_in_time()
andinterpolate_variant()
.Closes: #80627