Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextServer] Fix SVG emoji placement. #81103

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Aug 29, 2023

Fix SVG emoji placement, which seems to be broken by ThorVG update.

@bruvzg bruvzg added this to the 4.2 milestone Aug 29, 2023
@Riteo
Copy link
Contributor

Riteo commented Aug 29, 2023

Does this fix #80766? I wanted to add a bugsquad edit but I'm not sure.

@bruvzg
Copy link
Member Author

bruvzg commented Aug 29, 2023

Does this fix #80766? I wanted to add a bugsquad edit but I'm not sure.

No, Apple Emoji font is not SVG and will need a separate fix (I'm not sure what's wrong in this case).

@bruvzg bruvzg marked this pull request as ready for review August 30, 2023 05:28
@bruvzg bruvzg requested a review from a team as a code owner August 30, 2023 05:28
@akien-mga akien-mga merged commit 3f7c1bc into godotengine:master Aug 30, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants