Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign extension validation files to the GDExtension and .NET teams in CODEOWNERS #81116

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

raulsntos
Copy link
Member

As discussed in Rocket Chat.

I originally also wanted to assign the files that end with _extension to the GDExtension team, but I think that would override their current owner unless we explicitly add both which means we can't use a simple regex like *_extension.* but instead would have to add one for each area (e.g.: /modules/openxr/**/*_extension.*, /servers/text/**/*_extension.*).

@raulsntos raulsntos added this to the 4.2 milestone Aug 29, 2023
@raulsntos raulsntos requested a review from a team as a code owner August 29, 2023 11:01
@akien-mga akien-mga merged commit 7063009 into godotengine:master Aug 29, 2023
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@raulsntos raulsntos deleted the codeowners-gdextension branch August 29, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants