Fix a crash when built-in script is not saved and have syntax error #81156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When built-in script is not saved, it has empty path, and origin code assumes error with empty path is a depended_error but that's not always the case. Also add protection before access list index 0.
akien-mga
added
crash
cherrypick:4.1
KoBeWi
approved these changes
Aug 30, 2023
|
Thanks! |
jsjtxietian
deleted the
fix-crash-when-built-in-scripts-not-saved-and-have-error
branch
YuriSizov
removed
the
cherrypick:4.1
|
This fix depends on #75216, which is not cherry-pickable and may in fact be the source of the bug. Report only refers to a 4.2 dev snapshot, and not previous 4.x releases. If the issue is also present in 4.1, a dedicated PR would be appreciated. |
|
#79920 can also fix this crash (it's not a proper fix for this issue, but it works), so it can be cherry-picked instead. |
Sure, this seems like a good usability fix worth a cherry-pick in and of itself 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #81149.
When built-in script is not saved, it has empty path, and origin code assumes error with empty path is a depended_error but that's not always the case. When error's path and script's path are both empty, maybe we can believe it is an error caused by a script that's not been saved instead of a depended error.
Also add some protection before access error list's index 0.