Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix int's C# documentation #81227

Merged
merged 1 commit into from
Sep 2, 2023
Merged

Conversation

raulsntos
Copy link
Member

  • There's no implicit conversion from double to int, a cast was missing.
  • The example about literals in GDScript also applies to C# (with the same syntax even).

This documentation was added in #70046 which was merged in 4.1 and cherry-picked to 4.0 so I added the cherry-pick labels accordingly.

- There's no implicit conversion from `double` to `int`, a cast was missing.
- The example about literals in GDScript also applies to C# (with the same syntax even).
@raulsntos raulsntos added documentation topic:dotnet cherrypick:4.0 cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Sep 1, 2023
@raulsntos raulsntos added this to the 4.x milestone Sep 1, 2023
@raulsntos raulsntos requested a review from a team as a code owner September 1, 2023 15:27
@YuriSizov YuriSizov modified the milestones: 4.x, 4.2 Sep 1, 2023
@akien-mga akien-mga merged commit 865879f into godotengine:master Sep 2, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@raulsntos raulsntos deleted the docs/int branch September 2, 2023 13:55
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 24, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.3.

@akien-mga akien-mga added the bug label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants