-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Update AABB get_support
description
#81249
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! The final step before merging is to squash all the commits together so that the whole PR only contains 1 big commit with all your changes. We like to merge one commit at a time to keep the git history clean and navigable.
If you don't know how to do that, we have a helpful tutorial in the official documentation https://docs.godotengine.org/en/latest/community/contributing/pr_workflow.html#the-interactive-rebase
get_support
descriptionget_support
description
This is a simple documentation edit. It updates the description of the get_support method in AABB to explain what a support point is.
Apologies for the delay, I've squashed all commits |
Just want to check about what the process is here, or what boxes need to be checked before this can be merged? Thanks! I'm sure you're all super busy with the Unity refugees so I really appreciate the time (: |
You don't need to do anything further, once approved it's ready to merge by the production team, when we get to it. |
Thanks! And congrats for your first merged Godot contribution 🎉 |
This is a simple documentation edit. It updates the description of the
get_support
method inAABB
to explain what a support point is.