Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ItemList not updating when icon scale changes #81268

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Fix ItemList not updating when icon scale changes #81268

merged 1 commit into from
Sep 6, 2023

Conversation

timothyqiu
Copy link
Member

Fixes #74223

@timothyqiu timothyqiu added bug topic:gui cherrypick:4.0 cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Sep 3, 2023
@timothyqiu timothyqiu added this to the 4.2 milestone Sep 3, 2023
@timothyqiu timothyqiu requested a review from a team as a code owner September 3, 2023 11:24
@AThousandShips AThousandShips changed the title Fix ItemList not update when icon scale changes Fix ItemList not updateing when icon scale changes Sep 3, 2023
@AThousandShips AThousandShips changed the title Fix ItemList not updateing when icon scale changes Fix ItemList not updating when icon scale changes Sep 3, 2023
YuriSizov
YuriSizov approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense!

@YuriSizov YuriSizov merged commit 6f87ab7 into godotengine:master Sep 6, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@timothyqiu timothyqiu deleted the icon-scale-changes branch September 6, 2023 13:13
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.2.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriSizov YuriSizov YuriSizov approved these changes

Assignees
No one assigned
Labels
bug topic:gui
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

ItemList does not update when change property
2 participants
@timothyqiu @YuriSizov