Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show doc tooltips when hovering properties in the theme editor #81284

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Show doc tooltips when hovering properties in the theme editor #81284

merged 1 commit into from
Oct 6, 2023

Conversation

YeldhamDev
Copy link
Member

Just a small QOL thing I wanted to do in a while. I took some inspiration from dalexeev's work in the signal dock on how to implement it.

image

@YeldhamDev YeldhamDev added this to the 4.2 milestone Sep 3, 2023
@YeldhamDev YeldhamDev force-pushed the this_one_was_in_the_backlog_for_a_while branch from fbe0091 to 6fcff18 Compare September 3, 2023 22:44
@YeldhamDev YeldhamDev force-pushed the this_one_was_in_the_backlog_for_a_while branch from 6fcff18 to fed19ba Compare September 4, 2023 10:54
@YeldhamDev YeldhamDev mentioned this pull request Sep 21, 2023
Merged
@YuriSizov YuriSizov marked this pull request as draft September 29, 2023 12:02
@YuriSizov
Copy link
Contributor

Let's draft it until #82051 is ready.

@YeldhamDev YeldhamDev force-pushed the this_one_was_in_the_backlog_for_a_while branch from fed19ba to 85904de Compare October 4, 2023 14:48
@YeldhamDev YeldhamDev force-pushed the this_one_was_in_the_backlog_for_a_while branch from 85904de to 34e6b86 Compare October 4, 2023 14:53
@YeldhamDev YeldhamDev marked this pull request as ready for review October 4, 2023 14:55
@YeldhamDev
Copy link
Member Author

This PR now makes use of the new EditorHelpTooltip and it's ready for review.

YuriSizov
YuriSizov approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as desired, good job!

@akien-mga akien-mga merged commit 7b999ee into godotengine:master Oct 6, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@YeldhamDev YeldhamDev deleted the this_one_was_in_the_backlog_for_a_while branch October 7, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga left review comments

@YuriSizov YuriSizov YuriSizov approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor usability
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@YeldhamDev @YuriSizov @akien-mga