Fix description of dock slot usage in the documentation #81445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothyqiu
added
bug
documentation
cherrypick:4.1
akien-mga
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
Seems fine.
For the record (but that's not necessarily for this PR), all the left/right APIs and descriptions in this class assume Left-To-Right layout, and would be backwards when using a Right-To-Left layout / UI mirroring.
Probably overkill to add it in the description of each item, and we can't rename APIs, but this could be explained in the class description as a note.
YuriSizov
approved these changes
Sep 8, 2023
timothyqiu
force-pushed
the
default-layout
branch
from
5b315fa
to
6cdf5ef
Compare
AThousandShips
approved these changes
Sep 8, 2023
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default layout uses the upper-left slot.