Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve undo action names #81569

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Conversation

timothyqiu
Copy link
Member

  • Avoid concating strings manually for better i18n and easy l10n
    • Use vformat when possible
    • Use separate strings if the changing part is only a few hardcoded strings
  • Don't put a period at the end of the name

The format of these two is also changed from Do Something 'object' to Do Something: object since most other names use this format and the names won't be empty.

undo_redo->create_action(vformat(TTR("Edit Built-in Action: %s"), p_name));

undo_redo->create_action(vformat(TTR("Edit Shortcut: %s"), p_path));

* Avoid concating strings manually for better i18n and easy l10n
   * Use `vformat` when possible
   * Use separate strings if the changing part is only a few hardcoded strings
* Don't put a period at the end of the name
@timothyqiu timothyqiu added this to the 4.2 milestone Sep 12, 2023
@timothyqiu timothyqiu requested a review from a team as a code owner September 12, 2023 11:03
@timothyqiu timothyqiu removed the request for review from a team September 12, 2023 11:04
@akien-mga akien-mga merged commit 3ed4497 into godotengine:master Sep 12, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the action-name branch September 12, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants