Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Move bindings_generator warnings to .editorconfig #81703

Merged
merged 1 commit into from
Sep 18, 2023
Merged

C#: Move bindings_generator warnings to .editorconfig #81703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions modules/mono/editor/bindings_generator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -989,9 +989,6 @@ void BindingsGenerator::_generate_global_constants(StringBuilder &p_output) {

p_output.append("namespace " BINDINGS_NAMESPACE ";\n\n");

p_output.append("\n#pragma warning disable CS1591 // Disable warning: "
"'Missing XML comment for publicly visible type or member'\n");

p_output.append("public static partial class " BINDINGS_GLOBAL_SCOPE_CLASS "\n{");

for (const ConstantInterface &iconstant : global_constants) {
Expand Down Expand Up @@ -1089,8 +1086,6 @@ void BindingsGenerator::_generate_global_constants(StringBuilder &p_output) {
p_output.append(CLOSE_BLOCK);
}
}

p_output.append("\n#pragma warning restore CS1591\n");
}

Error BindingsGenerator::generate_cs_core_project(const String &p_proj_dir) {
Expand Down Expand Up @@ -1406,12 +1401,6 @@ Error BindingsGenerator::_generate_cs_type(const TypeInterface &itype, const Str
output.append("using System.Diagnostics;\n"); // DebuggerBrowsable
output.append("using Godot.NativeInterop;\n");

output.append("\n"
"#pragma warning disable CS1591 // Disable warning: "
"'Missing XML comment for publicly visible type or member'\n"
"#pragma warning disable CS1573 // Disable warning: "
"'Parameter has no matching param tag in the XML comment'\n");

output.append("\n#nullable disable\n");

const DocData::ClassDoc *class_doc = itype.class_doc;
Expand Down Expand Up @@ -1904,10 +1893,6 @@ Error BindingsGenerator::_generate_cs_type(const TypeInterface &itype, const Str

output.append(CLOSE_BLOCK /* class */);

output.append("\n"
"#pragma warning restore CS1591\n"
"#pragma warning restore CS1573\n");

return _save_file(p_output_file, output);
}

Expand Down
4 changes: 4 additions & 0 deletions modules/mono/glue/GodotSharp/.editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,7 @@ dotnet_diagnostic.CA1062.severity = error
dotnet_diagnostic.CA1069.severity = none
# CA1708: Identifiers should differ by more than case
dotnet_diagnostic.CA1708.severity = none
# CS1591: Missing XML comment for publicly visible type or member
dotnet_diagnostic.CS1591.severity = none
# CS1573: Parameter has no matching param tag in the XML comment
dotnet_diagnostic.CS1573.severity = none
Loading