Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change icon for position key #81751

Merged
merged 1 commit into from
Sep 17, 2023
Merged

Change icon for position key #81751

merged 1 commit into from
Sep 17, 2023

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Sep 16, 2023

@KoBeWi KoBeWi added this to the 4.2 milestone Sep 16, 2023
@KoBeWi KoBeWi requested a review from a team as a code owner September 16, 2023 18:30
@Mickeon
Copy link
Contributor

Mickeon commented Sep 16, 2023

I suppose nothing much can be done for it looking more like DOS than POS, but it is an improvement

@MewPurPur
Copy link
Contributor

I don't think we need to compromise like this, let me try.

@MewPurPur
Copy link
Contributor

MewPurPur commented Sep 16, 2023

image

KeyTrackPosition: <svg height="16" viewBox="0 0 16 16" width="16" xmlns="http://www.w3.org/2000/svg"><path d="M4.226 3.46a.76.76 0 0 0 0 1.078L7.46 7.775a.76.76 0 0 0 1.078 0l3.236-3.236a.76.76 0 0 0 0-1.078L8.54.225a.76.76 0 0 0-1.08 0zM8 9a3 3 0 0 0 0 6 3 3 0 0 0 0-6zm0 2a1 1 0 0 1 0 2 1 1 0 0 1 0-2zm5-2a1 1 0 0 0 0 4h-2v2h2a1 1 0 0 0 0-4h2V9zM0 9h2a2.5 2.5 0 0 1 0 5v2H0zm2 3.5a1 1 0 0 0 0-2z" fill="#e0e0e0"/></svg>

KeyTrackRotation: <svg height="16" viewBox="0 0 16 16" width="16" xmlns="http://www.w3.org/2000/svg"><path d="M4.226 3.46a.76.76 0 0 0 0 1.078L7.46 7.775a.76.76 0 0 0 1.078 0l3.236-3.236a.76.76 0 0 0 0-1.078L8.54.225a.76.76 0 0 0-1.08 0zM11 7v5a3 3 0 0 0 3 3h1v-2h-1a1 1 0 0 1-1-1v-1h2V9h-2V7zm0 5a3 3 0 0 0-6 0 3 3 0 0 0 6 0zM4 9a3 3 0 0 0-3 3v3h2v-3a1 1 0 0 1 1-1h1V9zm4 2a1 1 0 0 1 0 2 1 1 0 0 1 0-2z" fill="#e0e0e0"/></svg>

KeyTrackScale: <svg height="16" viewBox="0 0 16 16" width="16" xmlns="http://www.w3.org/2000/svg"><path d="M4.226 3.46a.76.76 0 0 0 0 1.078L7.46 7.775a.76.76 0 0 0 1.078 0l3.236-3.236a.76.76 0 0 0 0-1.078L8.54.225a.76.76 0 0 0-1.08 0zM11 7v5a3 3 0 0 0 3 3h1v-2h-1a1 1 0 0 1-1-1V7zM3 9a2 2 0 1 0 0 4H1v2h2a2 2 0 1 0 0-4h2V9zm6 0a3 3 0 1 0 0 6h1v-2H9a1 1 0 0 1 0-2h1V9z" fill="#e0e0e0"/></svg>

@KoBeWi
Copy link
Member Author

KoBeWi commented Sep 16, 2023

image

@fire fire requested a review from a team September 16, 2023 21:47
@fire
Copy link
Member

fire commented Sep 16, 2023

I'm personally ok with it, I wonder what @TokageItLab thinks.

@TokageItLab
Copy link
Member

I am a little concerned about the inconsistent thickness of the lines.

@MewPurPur
Copy link
Contributor

Version with slightly higher thickness, should be a fair tradeoff between the descender length and the thickness of the bowl:

<svg height="16" viewBox="0 0 16 16" width="16" xmlns="http://www.w3.org/2000/svg"><path d="M4.226 3.46a.76.76 0 0 0 0 1.078L7.46 7.775a.76.76 0 0 0 1.078 0l3.236-3.236a.76.76 0 0 0 0-1.078L8.54.225a.76.76 0 0 0-1.08 0zM8 9a3 3 0 0 0 0 6 3 3 0 0 0 0-6zm0 2a1 1 0 0 1 0 2 1 1 0 0 1 0-2zm5-2a1 1 0 0 0 0 4h-2v2h2a1 1 0 0 0 0-4h2V9zM0 9h2a2.7 2.7 0 0 1 0 5.4V16H0zm2 3.7a1 1 0 0 0 0-2z" fill="#e0e0e0"/></svg>

@KoBeWi
Copy link
Member Author

KoBeWi commented Sep 16, 2023

image

@akien-mga akien-mga merged commit 4df80b0 into godotengine:master Sep 17, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the locition branch September 17, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants