Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make editor camera speed indicator use m/s and m #81810

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Make editor camera speed indicator use m/s and m #81810

merged 1 commit into from
Sep 18, 2023

Conversation

AThousandShips
Copy link
Member

No description provided.

@AThousandShips AThousandShips added this to the 4.2 milestone Sep 17, 2023
@AThousandShips AThousandShips requested a review from a team as a code owner September 17, 2023 15:49
@AThousandShips AThousandShips added cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release enhancement labels Sep 17, 2023
@AThousandShips AThousandShips marked this pull request as draft September 17, 2023 15:54
@AThousandShips AThousandShips changed the title Make editor camera speed indicator use m/s Make editor camera speed indicator use m/s and m Sep 17, 2023
@AThousandShips AThousandShips marked this pull request as ready for review September 17, 2023 16:00
@AThousandShips AThousandShips changed the title Make editor camera speed indicator use m/s and m Make editor camera speed indicator use m/s Sep 17, 2023
@AThousandShips
Copy link
Member Author

AThousandShips commented Sep 17, 2023 •
edited
Loading

Unsure if the normal camera indicator, which represents cursor.distance, is also meters

Edit: Adding for now, will remove if incorrect

Edit 2: Looks like meters from an intuitive zooming around

@AThousandShips AThousandShips changed the title Make editor camera speed indicator use m/s Make editor camera speed indicator use m/s and m Sep 17, 2023
Calinou
Calinou approved these changes Sep 17, 2023
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context, these were initially displayed as "units" as meter suffixes weren't present in inspector properties at the time I added these labels.

It makes sense to call them meters, now that we use this terminology elsewhere in the editor.

@akien-mga akien-mga merged commit 9892bc2 into godotengine:master Sep 18, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@AThousandShips
Copy link
Member Author

Thank you!

@AThousandShips AThousandShips deleted the camera_m branch September 18, 2023 08:50
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.2.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

@aaronfranke aaronfranke aaronfranke approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
5 participants
@AThousandShips @akien-mga @YuriSizov @Calinou @aaronfranke