Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Add Vector2/3/4i.MAX and MIN #81819

Merged
merged 1 commit into from
Sep 19, 2023
Merged

C#: Add Vector2/3/4i.MAX and MIN #81819

merged 1 commit into from
Sep 19, 2023

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Sep 17, 2023 •
edited
Loading

Continuation of #81741 (for C#).

@Chaosus Chaosus requested a review from a team as a code owner September 17, 2023 18:01
@Chaosus Chaosus added this to the 4.2 milestone Sep 17, 2023
raulsntos
raulsntos approved these changes Sep 17, 2023
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit with the documentation, but otherwise looks great. Thanks!

modules/mono/glue/GodotSharp/GodotSharp/Core/Vector4I.cs Outdated Show resolved Hide resolved
modules/mono/glue/GodotSharp/GodotSharp/Core/Vector4I.cs Outdated Show resolved Hide resolved
@akien-mga akien-mga merged commit c78d0e2 into godotengine:master Sep 19, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus deleted the cs_max_min_vectors branch September 19, 2023 07:44
@akien-mga akien-mga changed the title Add Vector2/3/4i.MAX and MIN (C#) C#: Add Vector2/3/4i.MAX and MIN Oct 3, 2023
@raulsntos raulsntos mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulsntos raulsntos raulsntos approved these changes

Assignees
No one assigned
Labels
enhancement topic:dotnet
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@Chaosus @akien-mga @raulsntos