Improve retarget auto-mapping algorithm #81843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
added
cherrypick:4.1
|
I'll try to take a look, was busy with the fbx importer. |
SaracenOne
approved these changes
Sep 26, 2023
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, the model does not have Hips and Neck, but only a spine, as in the case of bones created with Blender's rigify.
The current auto-mapping requires Hips as a prerequisite, and if Hips cannot be guessed, everything fails. So this fix make it search for Hips candidates with "Spine" as the word with the lowest priority.
Also, make the Neck mapping be done after the Shoulder mapping. This will make sure that the Neck is guessed child of bone which the parent of the shoulder (or hand) cross with having "spine" name.