Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "Add" button consistency in Project Settings #81905

Merged

Conversation

ckaiser
Copy link
Contributor

@ckaiser ckaiser commented Sep 19, 2023

There's a few inconsistencies I've noticed while using the project settings window, mainly in places where we have a textbox with a button next to them that we're using to "Add" things.

This PR attempts to make all of these tabs behave more consistently and tidy up some minor UX things:

  • Adds a plus icon icon to all the "Add" buttons next to text inputs, with the hopes of making them more distinguishable
  • Adds a separator next to the action map "add" button for clarity
  • Modifies the Shader Globals editor to be consistent with the others (moving the name based error to the button popup, I kept the other errors in the message boxes since I'm unsure if those are more expensive checks that might not be wise to make every time there's a change in the input and they're a bit less obvious than an empty input or a bad character)
  • Adds the "Clear" button to the shader globals input since we may not want to clear it entirely when adding a new variable in case we're doing something sequential "var1, var2, var3", but if we're adding multiple variables at time, just clicking on the clear button and typing a new name to add a second variable is convenient.

Before and after screenshot:
before_and_after

I took the liberty of going directly to my first PR without creating a proposal for this because I figured it was a small thing, but I'm not super familiar with how the process goes for things like this usually, since this isn't really a "fix" or a "feature" per-se, and I have some more ideas for things I'd like to implement on the UX side of the editor, mostly minor like this, would making a proposal for several changes for a single window/panel/widget make sense or should I just keep making direct PRs as long as the changes are minor and in line with how things in the editor usually work?

@ckaiser ckaiser requested a review from a team as a code owner September 19, 2023 08:31
@AThousandShips AThousandShips added this to the 4.x milestone Sep 19, 2023
@ckaiser ckaiser force-pushed the feature/project_settings_add_consistency branch from 5d5587e to de45e64 Compare December 17, 2023 23:38
@clayjohn clayjohn requested review from a team and removed request for a team January 8, 2024 01:04
@KoBeWi
Copy link
Member

KoBeWi commented Jan 10, 2024

Global Groups tab also needs similar treatment (it was added after this PR was opened).

@ckaiser ckaiser force-pushed the feature/project_settings_add_consistency branch from de45e64 to 60ad6a2 Compare January 11, 2024 02:27
@ckaiser
Copy link
Contributor Author

ckaiser commented Jan 11, 2024

Global Groups tab also needs similar treatment (it was added after this PR was opened).

I can tackle that in another PR then :)

@KoBeWi
Copy link
Member

KoBeWi commented Jan 11, 2024

It should be in this PR, it's part of the same dialog.

 * Adds an icon to all the input-adjacent add/remove buttons
 * Adds a separator next to the action map "add" button
 * Changes the Shader Globals editor to be consistent with the others
 * Adds a clear button to the shader global name input
@ckaiser ckaiser force-pushed the feature/project_settings_add_consistency branch from 60ad6a2 to 1910f91 Compare January 11, 2024 20:13
@ckaiser
Copy link
Contributor Author

ckaiser commented Jan 11, 2024

It should be in this PR, it's part of the same dialog.

Alright, done! Updated the branch as well

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Jan 11, 2024
@akien-mga akien-mga merged commit 9c91fbe into godotengine:master Jan 15, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants