Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macOS export] Fix GDExtension framework +x flag errors, allow recursive signing on non macOS platform. #81969

Merged
merged 1 commit into from
Oct 3, 2023
Merged

[macOS export] Fix GDExtension framework +x flag errors, allow recursive signing on non macOS platform. #81969

merged 1 commit into from
Oct 3, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Sep 20, 2023

  • Fixes error messages when trying to set +x flag on the framework.
  • Allows recursive signing on non macOS platform (rcodesign seems to be buggy, so this still won't work for GDExtension frameworks).
  • Adds hardened runtime flag to rcodesign (same as used with Apple codesign).

@bruvzg bruvzg added this to the 4.x milestone Sep 20, 2023
@bruvzg bruvzg marked this pull request as ready for review September 26, 2023 06:52
@bruvzg bruvzg requested a review from a team as a code owner September 26, 2023 06:52
@akien-mga akien-mga changed the title [macOS export] Fix GDExtension framework +x flag errors, allow recursive signing on non macOS platform. [macOS export] Fix GDExtension framework +x flag errors, allow recursive signing on non macOS platform. Oct 3, 2023
@akien-mga akien-mga modified the milestones: 4.x, 4.2 Oct 3, 2023
@akien-mga akien-mga merged commit 5d30001 into godotengine:master Oct 3, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement platform:macos topic:export
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@bruvzg @akien-mga