Fix leak when calling remove_control_from_menu_panel
#82171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriSizov
approved these changes
Sep 23, 2023
|
Ah, but the same needs to be done in the canvas item editor plugin as well, the code is identical between the two. |
timothyqiu
force-pushed
the
sep-leak
branch
from
968a12d
to
2d67ce4
Compare
timothyqiu
changed the title
Node3DEditor::remove_control_from_menu_panelremove_control_from_menu_panel
YuriSizov
approved these changes
Sep 24, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The separator allocated in
add_control_to_menu_panel()was never freed.The separator will be leaked if
remove_control_from_menu_panel()is called.