Fix GLTF importer forcing vertex colors on all materials #82272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The importer already checks if a mesh has vertex colors and enables vertex colors on the material using it. Before this fix, GLTF importer would force shader generation to use vertex colors even if the scene did not have vertex colors at all, or did not need them; causing inefficient shader and PSO generation.
|
This fix does not fix projects with already-imported GLTF meshes. Meshes will have to be reimported to take advantage of the fix. Visually, this bug is harmless. It only affects performance (and mostly low end, since high end will probably not bottlenecked by this). |
fire
approved these changes
Sep 25, 2023
|
Thanks! |
akien-mga
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The importer already checks if a mesh has vertex colors and enables vertex colors on the material using it.
Before this fix, GLTF importer would force shader generation to use vertex colors even if the scene did not have vertex colors at all, or did not need them for some of its meshes; causing inefficient shader and PSO generation.