Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leak when closing theme editor preview tabs #82442

Conversation

YuriSizov
Copy link
Contributor

Fixes #81085.

@YuriSizov YuriSizov added bug topic:editor crash cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Sep 27, 2023
@YuriSizov YuriSizov added this to the 4.2 milestone Sep 27, 2023
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine!

@YuriSizov YuriSizov merged commit 46e48c5 into godotengine:master Sep 27, 2023
15 checks passed
@YuriSizov YuriSizov deleted the theme-editor-release-me-from-this-nightmare-where-i-try-to-escape-the-editor-but-it-doesnt-let-me-go-and-i-keep-running-and-running-and-eventually-a-little-leak-comes-out branch September 27, 2023 18:59
@YuriSizov
Copy link
Contributor Author

Cherry-picked for 4.1.2.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Sep 27, 2023
@MewPurPur
Copy link
Contributor

MewPurPur commented Sep 27, 2023

you mean... "FREE me from this nightmare"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor crashes and leaks RIDs when you open and close a custom theme preview tab
3 participants