-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to put TabContainer tabs at bottom #82468
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a specific set of theme styles for the upside-down tabs.
and especially for the future, this should be an enum. Right now it would only contain |
Related: #63873 |
4efc8a2
to
a215a97
Compare
a215a97
to
87e4ec9
Compare
df15d2e
to
84869ff
Compare
fixed docs and don't override type variation if set |
c0218fc
to
59ecaff
Compare
changed to use theme item for _bottom styles in tab container. I found a way to not have to modify TabBar at all using the theme overrides! That was a big concern I had with this method originally. I am now looking into flipping the StyleBox automatically |
59ecaff
to
5e919ec
Compare
Now automatically flips the tab's stylebox instead of using separate theme items. |
7daba2d
to
8239817
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8239817
to
68deb34
Compare
Rebased and fixed merge conflicts. |
68deb34
to
90f216f
Compare
scene/gui/tab_container.cpp
Outdated
@@ -198,6 +220,8 @@ void TabContainer::_on_theme_changed() { | |||
return; | |||
} | |||
|
|||
tab_bar->set_tab_style_v_flip(tabs_position == POSITION_BOTTOM); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this here if it doesn't depend on the theme?
90f216f
to
f6a2128
Compare
Thanks! |
part of: godotengine/godot-proposals#1986
salvaged: #44420
Adds
tabs_at_bottom
to TabContainer.Enabling will move the tab bar to the bottom.